netdev - Re: [PATCH net-next 0/8] tg3: Bugfixes and updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101001172545.GA17223@mcarlson.broadcom.com>
Date:	Fri, 1 Oct 2010 10:25:45 -0700
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"David Miller" <davem@...emloft.net>
cc:	"Matthew Carlson" <mcarlson@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"andy@...yhouse.net" <andy@...yhouse.net>
Subject: Re: [PATCH net-next 0/8] tg3: Bugfixes and updates

On Fri, Oct 01, 2010 at 12:26:28AM -0700, David Miller wrote:
> From: "Matt Carlson" <mcarlson@...adcom.com>
> Date: Thu, 30 Sep 2010 13:34:29 -0700
> 
> > This patchset implements some bugfixes, removes the 5724 device
> > ID and introduces extended rx buffer rings.
> 
> All applied....
> 
> But really, I want to hear some real justification for a 2048 entry RX
> ring at gigabit speeds.  I even think 512 is way too large for gigabit
> parts.

I don't have any personal experience where a larger ring size could
benefit.  However, I have heard of situations in the past where people
have said increasing the amount of rx buffers available has smoothed
over some bursty traffic / cpu usage patterns.  These people really did
want more than 512 rx buffers.

> Any machine that gets one of these newer 5717 parts does not need that
> much queueing, and too deep queues tend to hurt locality and thus
> performance.

Good point.  I'll see if we can scale the BD ring size based on the
number of rx buffers the administrator has configured.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html