netdev - Re: [PATCH net-next-2.6] be2net: add multiple RX queue support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100930.173957.55855786.davem@davemloft.net>
Date:	Thu, 30 Sep 2010 17:39:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sathya.perla@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] be2net: add multiple RX queue support

From: Sathya Perla <sathya.perla@...lex.com>
Date: Wed, 29 Sep 2010 17:31:13 +0530

> @@ -78,6 +78,13 @@ static inline char *nic_name(struct pci_dev *pdev)
>  #define MCC_Q_LEN		128	/* total size not to exceed 8 pages */
>  #define MCC_CQ_LEN		256
>  
> +#ifdef CONFIG_PPC64			/* ppc platforms support only max of */
> +#define NUM_RSS_QS		2	/* 4 msix vectors per pci function   */
> +#else
> +#define NUM_RSS_QS		4	/* BE limit is 4 queues/port	     */
> +#endif

If the first hunk I see in a patch is something like this, it is
not a good sign.

This is something you need to discover dynamically, and the MSI-X
vector enable functions in the kernel allow you to do this just fine.

Look at what other drivers do, they have a specific number of vectora
they try to obtain using pci_enable_msix(), and if that fails they
decrease the vector count until they are able to succeed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html