netdev - Re: [PATCH v12 06/17] Use callback to deal with skb_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101001.001439.85411154.davem@davemloft.net>
Date:	Fri, 01 Oct 2010 00:14:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiaohui.xin@...el.com
Cc:	netdev@...r.kernel.org, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, mst@...hat.com, mingo@...e.hu,
	herbert@...dor.apana.org.au, jdike@...ux.intel.com
Subject: Re: [PATCH v12 06/17] Use callback to deal with skb_release_data()
 specially.

From: xiaohui.xin@...el.com
Date: Thu, 30 Sep 2010 22:04:23 +0800

> @@ -197,10 +197,11 @@ struct skb_shared_info {
>  	union skb_shared_tx tx_flags;
>  	struct sk_buff	*frag_list;
>  	struct skb_shared_hwtstamps hwtstamps;
> -	skb_frag_t	frags[MAX_SKB_FRAGS];
>  	/* Intermediate layers must ensure that destructor_arg
>  	 * remains valid until skb destructor */
>  	void *		destructor_arg;
> +
> +	skb_frag_t	frags[MAX_SKB_FRAGS];
>  };
>  
>  /* The structure is for a skb which pages may point to

Why are you moving frags[] to the end like this?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html