netdev - Re: [PATCH v2 1/2] Phonet: Implement Pipe Controller to support Nokia Slim Modems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101001085553.GA27109@bnru01.bnr.st.com>
Date:	Fri, 1 Oct 2010 14:25:55 +0530
From:	Kumar SANGHVI <kumar.sanghvi@...ricsson.com>
To:	Rémi Denis-Courmont <remi@...lab.net>
Cc:	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	STEricsson_nomadik_linux <STEricsson_nomadik_linux@...t.st.com>,
	Sudeep DIVAKARAN <sudeep.divakaran@...ricsson.com>,
	Gulshan KARMANI <gulshan.karmani@...ricsson.com>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>
Subject: Re: [PATCH v2 1/2] Phonet: Implement Pipe Controller to support
 Nokia Slim Modems

Hi,

On Fri, Oct 01, 2010 at 10:42:44 +0200, Rémi Denis-Courmont wrote:
 > 
> > I have not introduced any new ioctl()'s as part of Pipe controller
> > implementation.
> 
> Sure. What you did is basically worse than ioctl()'s. You've implemented them 
> as socket options. Socket options are meant to configure parameters with 
> setsockopt and read paramters with getsockopt. They are not meant for 'doing' 
> things - that's what ioctl()'s are for.

Isn't the existing phonet stack 'doing' something as part of
PNPIPE_ENCAP rather than simply configuring some socket option or flag ?
 
> > Regarding implementing connect() socket call, few queries:
> > 1. It should carry out all the same steps which I am currently doing as
> > part of PIPE_CREATE socket option, right?
> > 2. Currently, as part of Pipe controller implementation, user-space
> >    follows below sequence:-
> > 	socket()
> > 	bind()
> > 	listen()
> > 	setsockopt(PIPE_CREATE)
> > 	accept()'
> > 
> >    In the phonet stack pipe controller logic, we wait for PEP_CONNECT_RESP
> >    from host-pep (GPRS socket or video telephony socket is a host-pep.
> >    pep_reply sends out the PEP_CONNECT_RESP) and remote-pep (modem),
> >    negotiate the best flow-control to be used, and then send
> >    PIPE_CREATED_IND, with selected flow-control to both pipe end-points.
> 
> connect() should replace listen(), PIPE_CREATE and accept().

Thanks. I will implement connect and upload the patch.

-Kumar.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html