netdev - Re: [PATCH] atmtcp: add sysfs attr for changing atm carrier signal state.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101003.130057.226762538.davem@davemloft.net>
Date:	Sun, 03 Oct 2010 13:00:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	karl@...amoto.org
Cc:	netdev@...r.kernel.org, linux-atm-general@...ts.sourceforge.net,
	chas@....nrl.navy.mil
Subject: Re: [PATCH] atmtcp: add sysfs attr for changing atm carrier signal
 state.

From: Karl Hiramoto <karl@...amoto.org>
Date: Sun,  3 Oct 2010 21:51:25 +0200

> This will be used for device testing carrier signal changes in other parts of
> the atm stack.
> 
> Carrier lost set by:
> echo -n 0 > /sys/class/atm/atmtcp0/carrier
> 
> Carrier detected:
> echo -n 1 > /sys/class/atm/atmtcp0/carrier
> 
> Signed-off-by: Karl Hiramoto <karl@...amoto.org>

We already have enough sysfs hacky knobs.

And for something as fundamental as setting the carrier status, it's
not acceptable to add a device-type specific control.

Use something we have already, either via core device state management
(via netlink or ifconfig's ioctls) or ethtool.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html