netdev - RE: To GRO or not to GRO...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <EA929A9653AAE14F841771FB1DE5A136602570A01D@rrsmsx501.amr.corp.intel.com>
Date:	Mon, 4 Oct 2010 11:48:46 -0600
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	David Miller <davem@...emloft.net>,
	"sysoleg@...dex.ru" <sysoleg@...dex.ru>
CC:	"richard@...ce.co.nz" <richard@...ce.co.nz>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: To GRO or not to GRO...

>-----Original Message-----
>From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On
>Behalf Of David Miller
>Sent: Sunday, October 03, 2010 12:31 AM
>To: sysoleg@...dex.ru
>Cc: richard@...ce.co.nz; netdev@...r.kernel.org
>Subject: Re: To GRO or not to GRO...
>
>From: "\"Oleg A. Arkhangelsky\"" <sysoleg@...dex.ru>
>Date: Sun, 03 Oct 2010 11:18:46 +0400
>
>>
>>
>> 03.10.2010, 03:17, "Richard Scobie" <richard@...ce.co.nz>:
>>
>>> In the README for ixgbe-2.1.4, is says:
>>>
>>> " Disable GRO when routing/bridging
>>>    ---------------------------------
>>>    Due to a known kernel issue, GRO must be turned off when
>>> routing/bridging.
>>>    GRO can be turned off via ethtool."
>>>
>>
>> This information is true for LRO, not GRO.
>
>Right.
>
>> I believe that this appeared when ixgbe was converted from LRO
>> to GRO and all occurrences of LRO was blindly replaced by GRO
>> everywhere.
>
>Someome please submit a patch to fix this, thanks.

The information referenced above is from the README included with the out-of-tree ixgbe driver which we provide for download at e1000.sf.net. 

The in-kernel docs are accurate AFAICT.

Thanks,
Emil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html