netdev - Re: [PATCH] Fix out-of-bounds reading in sctp_asoc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101003.220057.59686624.davem@davemloft.net>
Date:	Sun, 03 Oct 2010 22:00:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vladislav.yasevich@...com
Cc:	drosenberg@...curity.com, sri@...ibm.com,
	linux-sctp@...r.kernel.org, linux-kernel@...r.kernel.org,
	security@...nel.org, stable@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix out-of-bounds reading in sctp_asoc_get_hmac()

From: Vlad Yasevich <vladislav.yasevich@...com>
Date: Fri, 01 Oct 2010 18:13:34 -0400

> On 10/01/2010 05:51 PM, Dan Rosenberg wrote:
>> The sctp_asoc_get_hmac() function iterates through a peer's hmac_ids
>> array and attempts to ensure that only a supported hmac entry is
>> returned.  The current code fails to do this properly - if the last id
>> in the array is out of range (greater than SCTP_AUTH_HMAC_ID_MAX), the
>> id integer remains set after exiting the loop, and the address of an
>> out-of-bounds entry will be returned and subsequently used in the
>> parent
>> function, causing potentially ugly memory corruption.  This patch
>> resets
>> the id integer to 0 on encountering an invalid id so that NULL will be
>> returned after finishing the loop if no valid ids are found.
>>
>> Signed-off-by: Dan Rosenberg<drosenberg@...curity.com>
> 
> Good catch.
> 
> Acked-by: Vlad Yasevich <vladislav.yasevich@...com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html