netdev - Re: [PATCH] SIW: iWARP Protocol headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF381378D0.1649122C-ONC12577B3.0058222E-C12577B3.00587475@ch.ibm.com>
Date:	Tue, 5 Oct 2010 18:06:09 +0200
From:	Bernard Metzler <BMT@...ich.ibm.com>
To:	Steve Wise <swise@...ngridcomputing.com>
Cc:	linux-rdma@...r.kernel.org, linux-rdma-owner@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] SIW: iWARP Protocol headers

<snip>
> > + */
> > +struct iwarp_ctrl_tagged {
> > +   struct iwarp_ctrl   ctrl;
> > +   __u32         ddp_stag;
> > +   __u64         ddp_to;
> > +} __attribute__((__packed__));
> > +
> > 
> 
> All of the above header structures should use __beXX types since the 
> fields are all in Network Byte Order.
> 
right. will get fixed.

> Also, did you run sparse on the patches (Documentation/sparse.txt)?
> 
> 
frankly, i was not aware. sorry. will do.

bernard.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html