netdev - Re: [PATCH 1/2] net/phy: fix many "defined but unused" warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101005.003602.57483854.davem@davemloft.net>
Date:	Tue, 05 Oct 2010 00:36:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	u.kleine-koenig@...gutronix.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net/phy: fix many "defined but unused" warnings

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Date: Mon,  4 Oct 2010 11:43:32 +0200

> MODULE_DEVICE_TABLE only expdrivers/net/phy/bcm63xx.c:134: warning: 'bcm63xx_tbl' defined but not usedands to something if it's compiled
> for a module.  So when building-in support for the phys, the
> mdio_device_id tables are unused.  Marking them with __maybe_unused
> fixes the following warnings:
> 
> 	drivers/net/phy/bcm63xx.c:134: warning: 'bcm63xx_tbl' defined but not used
> 	drivers/net/phy/broadcom.c:933: warning: 'broadcom_tbl' defined but not used
> 	drivers/net/phy/cicada.c:162: warning: 'cicada_tbl' defined but not used
> 	drivers/net/phy/davicom.c:222: warning: 'davicom_tbl' defined but not used
> 	drivers/net/phy/et1011c.c:114: warning: 'et1011c_tbl' defined but not used
> 	drivers/net/phy/icplus.c:137: warning: 'icplus_tbl' defined but not used
> 	drivers/net/phy/lxt.c:226: warning: 'lxt_tbl' defined but not used
> 	drivers/net/phy/marvell.c:724: warning: 'marvell_tbl' defined but not used
> 	drivers/net/phy/micrel.c:234: warning: 'micrel_tbl' defined but not used
> 	drivers/net/phy/national.c:154: warning: 'ns_tbl' defined but not used
> 	drivers/net/phy/qsemi.c:141: warning: 'qs6612_tbl' defined but not used
> 	drivers/net/phy/realtek.c:82: warning: 'realtek_tbl' defined but not used
> 	drivers/net/phy/smsc.c:257: warning: 'smsc_tbl' defined but not used
> 	drivers/net/phy/ste10Xp.c:135: warning: 'ste10Xp_tbl' defined but not used
> 	drivers/net/phy/vitesse.c:195: warning: 'vitesse_tbl' defined but not used
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Unfortunate but necessary for now, so applied, thanks.

Maybe we can eventually put something into MODULE_DEVICE_TABLE to add a nop-style
reference, enough to shut up the compiler but not actually compile the table into
the code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html