netdev - Re: [PATCH] SIW: Module initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik5=i+A5_OpU0rVyfYi=ibgS9UWMu82vMCmM=PN@mail.gmail.com>
Date:	Tue, 5 Oct 2010 12:57:21 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Bernard Metzler <bmt@...ich.ibm.com>
Cc:	netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH] SIW: Module initialization

On Tue, Oct 5, 2010 at 8:54 AM, Bernard Metzler <bmt@...ich.ibm.com> wrote:
> +static int loopback_enabled;
> +module_param(loopback_enabled, int, 0644);
> +MODULE_PARM_DESC(loopback_enabled, "enable_loopback");

A minor comment: since kernel 2.6.31 the type "bool" can be used for
boolean kernel module parameters.

> + * TODO: Dynamic device management (network device registration/removal).

The current implementation is such that one siw device is created for
each network device found at kernel module load time. That means that
you force the user to load the siw kernel module after all other
kernel modules that register a network device. I'm not sure that's a
good idea.

> +                       if (!siw_device) {
> +                               siw_device = siw_p;
> +                               siw_p->next = NULL;
> +                       } else {
> +                               siw_p->next = siw_device->next;
> +                               siw_device->next = siw_p;
> +                       }

Why a custom linked list implementation instead of using <linux/list.h> ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html