[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1286289703.2796.292.camel@edumazet-laptop>
Date: Tue, 05 Oct 2010 16:41:43 +0200
From: Eric Dumazet <eric.dumazet@...il.com>
To: Jesper Dangaard Brouer <hawk@...x.dk>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: [net-next PATCH] igb: update adapter stats when reading
/proc/net/dev.
Le mardi 05 octobre 2010 à 16:18 +0200, Jesper Dangaard Brouer a écrit :
> Network driver igb: Improve the accuracy of stats in /proc/net/dev, by
> updating the adapter stats when reading /proc/net/dev. Currently the
> stats are updated by the watchdog timer every 2 sec, or when getting
> stats via ethtool -S.
>
> A number of userspace apps read these /proc/net/dev stats every second,
> e.g. ifstat, which then gives a perceived very bursty traffic pattern,
> which is actually false.
>
> Signed-off-by: Jesper Dangaard Brouer <hawk@...x.dk>
Unfortunately this is racy with igb_watchdog_task()
igb_update_stats() must be called under protection of a lock.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists