netdev - Re: [PATCH] SIW: Queue pair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimM3Lpmt3JLgbCtuCjqFjNb8AkvBpdzpN7Sx978@mail.gmail.com>
Date:	Wed, 6 Oct 2010 19:57:29 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Bernard Metzler <bmt@...ich.ibm.com>
Cc:	netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH] SIW: Queue pair

On Tue, Oct 5, 2010 at 8:55 AM, Bernard Metzler <bmt@...ich.ibm.com> wrote:
>
> [ ... ]
> +int
> +siw_qp_modify(struct siw_qp *qp, struct siw_qp_attrs *attrs,
> +             enum siw_qp_attr_mask mask)
> +{
> [ ... ]
> +               case SIW_QP_STATE_ERROR:
> +                       siw_rq_flush(qp);
> +                       qp->attrs.state = SIW_QP_STATE_ERROR;
> +                       drop_conn = 1;
> +                       break;

At least for InfiniBand when the state of a queue pair is changed to
Error, work requests must be completed in error. The above code just
flushes pending work requests. That doesn't look correct to me.

A quote from the InfiniBand Architecture Specification, table 91, QP
State Transition Properties:

Any state to Reset: QP attributes are reset to the same values after
the QP was created. Outstanding Work Requests are removed from the
queues without notifying the Consumer.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html