netdev - Re: [net-next-2.6 PATCH 2/3] bonding: add Speed/Duplex information to /proc/net/bonding/bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CACEADA.70009@ans.pl>
Date:	Wed, 06 Oct 2010 23:32:10 +0200
From:	Krzysztof Olędzki <ole@....pl>
To:	David Miller <davem@...emloft.net>
CC:	fubar@...ibm.com, bonding-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH 2/3] bonding: add Speed/Duplex information
 to /proc/net/bonding/bond

On 2010-10-06 23:24, David Miller wrote:
> From: Krzysztof Piotr Oledzki <ole@....pl>
> Date: Thu, 30 Sep 2010 18:19:04 +0200
>
>> Subject: bonding: add Speed/Duplex information to /proc/net/bonding/bond*
>>
>> Effect:
>>   Slave Interface: eth5
>>   MII Status: up
>>   Speed: 10000 Mbps
>>   Duplex: full
>>   Link Failure Count: 0
>>   Permanent HW addr: XX:XX:XX:XX:XX:XX
>>   Slave queue ID: 0
>>
>> Signed-off-by: Krzysztof Piotr Oledzki <ole@....pl>
>
> Changing the layout of a procfs file is pretty much always unsafe.
>
> Some useland program somewhere depends upon the current layout, and
> therefore very likely could break if we change the contents.
>
> We really can't apply a patch like this.  A most portable and
> extensible interface (netlink, ethtool) should be used to provide this
> information to userspace.

Sure, no problem.

Please note however that this procfs file was recently changed ("Slave 
queue ID" was added) so if this is indeed a problem than we would 
already heard about this.

Best regards,

			Krzysztof Olędzki
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html