lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.DEB.2.00.1010061443480.30674@justus.melware.de> Date: Wed, 6 Oct 2010 14:49:52 +0200 (CEST) From: Armin Schindler <armin@...ware.de> To: Dan Carpenter <error27@...il.com> cc: Karsten Keil <isdn@...ux-pingi.de>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] eicon: make buffer larger On Wed, 6 Oct 2010, Dan Carpenter wrote: > On Wed, Oct 06, 2010 at 10:44:47AM +0200, Armin Schindler wrote: >>> 927 strcpy (clients[id].drvName, tmp); >>> 928 strcpy (clients[id].Dbg.drvName, tmp); >>> ^ >>> this buffer is only 16 chars >> >> Now I understand. You are right. So the fix would be to change these >> strcpy() to e.g. strncpy() or similar. >> > > We need more than 16 characters to store the information. What is the > problem with just making the buffer larger? The larger buffer is not really needed. Later versions of the driver will use the strcpy/memcpy with checked size anyway. I just want to avoid a change in the debug structure which is used in more than one module/tool. But it shouldn't be a real problem. Armin -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists