netdev - Re: [PATCH] remove leftover rcu_read_unlock calls from __mkroute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1286513278.6536.470.camel@edumazet-laptop>
Date:	Fri, 08 Oct 2010 06:47:58 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dimitris Michailidis <dm@...lsio.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] remove leftover rcu_read_unlock calls from
 __mkroute_output

Le jeudi 07 octobre 2010 à 17:48 -0700, Dimitris Michailidis a écrit :
> Commit "fib: RCU conversion of fib_lookup()" removed rcu_read_lock() from
> __mkroute_output but left a couple of calls to rcu_read_unlock() in there.
> This causes lockdep to complain that the rcu_read_unlock() call in
> __ip_route_output_key causes a lock inbalance and quickly crashes the
> kernel. The below fixes this for me.
> 
> Signed-off-by: Dimitris Michailidis <dm@...lsio.com>

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Thanks Dimitris !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html