netdev - Re: [PATCH 4/5] rds: stop including asm-generic/bitops/le.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101008.115900.245387221.davem@davemloft.net>
Date:	Fri, 08 Oct 2010 11:59:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andy.grover@...cle.com
Cc:	akinobu.mita@...il.com, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, arnd@...db.de,
	akpm@...ux-foundation.org, rds-devel@....oracle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 4/5] rds: stop including asm-generic/bitops/le.h
 directly

From: Andy Grover <andy.grover@...cle.com>
Date: Fri, 08 Oct 2010 11:55:55 -0700

> On 10/08/2010 03:03 AM, Akinobu Mita wrote:
>> asm-generic/bitops/le.h is only intended to be included directly from
>> asm-generic/bitops/ext2-non-atomic.h or asm-generic/bitops/minix-le.h
>> which implements generic ext2 or minix bit operations.
>>
>> This stops including asm-generic/bitops/le.h directly and use ext2
>> non-atomic bit operations instead.
>>
>> An alternative approach is introducing little endian bit operations
>> in linux/bitops.h. But it needs to touch more files than this change
>> does.
> 
>> -	generic___set_le_bit(off, (void *)map->m_page_addrs[i]);
>> +	ext2_set_bit(off, (void *)map->m_page_addrs[i]);
> 
> I'd like a solution that doesn't have rds calling a function starting
> with ext2_. Seems wrong.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html