netdev - Re: [PATCH] net/fec: carrier off initially to avoid root mount failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101008.135021.242120920.davem@davemloft.net>
Date:	Fri, 08 Oct 2010 13:50:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	oskar@...utronix.de
Cc:	netdev@...r.kernel.org, dan@...eddedalley.com,
	bigeasy@...utronix.de, hjk@...utronix.de, gerg@...inux.org
Subject: Re: [PATCH] net/fec: carrier off initially to avoid root mount
 failure

From: Oskar Schirmer <oskar@...utronix.de>
Date: Fri, 8 Oct 2010 22:35:30 +0200

> So when asking for the most correct place to fix this, I'ld propose
> phylib itself: Shouldn't the correct carrier state be set with
> phy_start_machine or phy_device_create when phy state is set to
> PHY_DOWN?

I agree, phylib is the best place to handle this.

The carrier defaults to "on" for newly created net devices
since that's what software devices and hardware ones which
lack a link want.

phy_device_create() currently lacks access to the network device
struct.

phy_connect_direct() and phy_attach_direct() might be good spots.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html