lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4CB07EFB.4020307@kernel.org> Date: Sat, 09 Oct 2010 18:40:59 +0400 From: Denis Kirjanov <dkirjanov@...nel.org> To: Ben Hutchings <bhutchings@...arflare.com> CC: davem@...emloft.net, netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com> Subject: Re: [PATCH -next] sundance: Add initial ethtool stats support On 10/09/2010 05:27 PM, Ben Hutchings wrote: > Denis Kirjanov wrote: >> Add initial ethtool statistics support > [...] >> +static void get_ethtool_stats(struct net_device *dev, >> + struct ethtool_stats *stats, u64 *data) >> +{ >> + struct net_device_stats *netdev_stats = get_stats(dev); >> + int i = 0; >> + >> + data[i++] = netdev_stats->tx_packets; >> + data[i++] = netdev_stats->tx_bytes; >> + data[i++] = netdev_stats->rx_packets; >> + data[i++] = netdev_stats->rx_bytes; >> + data[i++] = netdev_stats->tx_errors; >> + data[i++] = netdev_stats->tx_dropped; >> + data[i++] = netdev_stats->rx_errors; >> +} > [...] > > There is no point in adding ethtool stats that merely mirror the baseline > net device stats. Fair enough, I'll add extra stats shortly > Ben. > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists