netdev - Re: [PATCH] forcedeth: reconfigure multicast packet filter only when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101009113213.62c2f131@nehalam>
Date:	Sat, 9 Oct 2010 11:32:13 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jindřich Makovička <makovick@...il.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net, aabdulla@...dia.com, ditto@...gle.com
Subject: Re: [PATCH] forcedeth: reconfigure multicast packet filter only
 when needed

On Sat, 9 Oct 2010 13:26:05 +0200
Jindřich Makovička <makovick@...il.com> wrote:

> +
> +	/* current packet filter state */
> +	u32 cur_pff;
> +	u32 cur_addr[2];
> +	u32 cur_mask[2];
>  };

No big deal, but couldn't you just put those temporary variables
on the stack. and reread the current value before stopping.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html