[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.01.1010090609350.1542@obet.zrqbmnf.qr>
Date: Sat, 9 Oct 2010 06:21:44 +0200 (CEST)
From: Jan Engelhardt <jengelh@...ozas.de>
To: Ben Hutchings <bhutchings@...arflare.com>
cc: Nicola <nicola.padovano@...il.com>,
netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] Tarpit target for the last stable (2.6.35.7): right
version
On Friday 2010-10-08 21:10, Ben Hutchings wrote:
>On Fri, 2010-10-08 at 21:01 +0200, Nicola wrote:
>> [Sorry for the inconvenience: I just noticed that Gmail has a bad
>> formatting. I resend the patch hoping that now things are right.]
>[...]
>
>It's still word-wrapped. You may have to make the patch an attachment,
>but see Documentation/email-clients.txt for configuration hints.
>
>It is also not based on the right version; networking patches adding new
>features should be based on David Miller's net-next-2.6 tree.
I must say I am surprised.
There already exists a maintained xt_TARPIT in Xtables-addons, and
it seems like your patch is a duplicate effort of it.
If you have any updates to xt_TARPIT, I would recommend the strategy
that Luciano Coelho used when he wanted to have xt_condition in
the main kernel:
1. take the maintained version from Xt-a
2. submit any updates to the Xt-a file, if feasible
3. once processed, submit that then for Linux kernel inclusion
4. apply further updates to the LK file, if needed
That way it is way easier to know what specifically new features you
have added to xt_TARPIT, if any.
thanks,
Jan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists