netdev - Re: [PATCH net-2.6] tg3: restore rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101011.160641.71122025.davem@davemloft.net>
Date:	Mon, 11 Oct 2010 16:06:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, mchan@...adcom.com
Subject: Re: [PATCH net-2.6] tg3: restore rx_dropped accounting

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Mon, 11 Oct 2010 15:26:57 -0700

> On Sun, Oct 10, 2010 at 10:55:52PM -0700, Eric Dumazet wrote:
>> commit 511d22247be7 (tg3: 64 bit stats on all arches), overlooked the
>> rx_dropped accounting.
>> 
>> We use a full "struct rtnl_link_stats64" to hold rx_dropped value, but
>> forgot to report it in tg3_get_stats64().
>> 
>> Use an "unsigned long" instead to shrink "struct tg3" by 176 bytes, and
>> report this value to stats readers.
>> 
>> Increment rx_dropped counter for oversized frames.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Acked-by: Matt Carlson <mcarlson@...adcom.com>

Applied, thanks Matt.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html