netdev - Re: [PATCH net-next] net dst: use a percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101011.161038.189691429.davem@davemloft.net>
Date:	Mon, 11 Oct 2010 16:10:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net dst: use a percpu_counter to track entries

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 11 Oct 2010 23:29:33 +0200

> Le lundi 11 octobre 2010 à 13:07 -0700, David Miller a écrit :
> 
>> When I first read the subject line for this patch, I was
>> scared, because I thought you were using a percpu counter
>> for dst entry refcounts :-)
>> 
>> Anyways this is fine, applied, thanks!
> 
> I though about a crazy idea for loopback device (but not a percpu
> counter for dst refcounts)
> 
> Add a cpu field somewhere so that each cpu manipulates a different dst.
> 
> Or maybe just never cache such dst, so that each tcp socket uses its own
> dst.

We could even make the cpu (in lieu of a socket) a key in the lookup,
but that would complicate handling things like PMTU indications and
redirects.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html