lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1286812009.2737.30.camel@edumazet-laptop> Date: Mon, 11 Oct 2010 17:46:49 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Michael Tokarev <mjt@....msk.ru> Cc: Andrey Vagin <avagin@...nvz.org>, stable@...nel.org, netdev@...r.kernel.org, Krishna Kumar <krkumar2@...ibm.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: [STABLE 2.6.32 PATCH] net: release dst entry while cache-hot for GSO case too Le lundi 11 octobre 2010 à 19:40 +0400, Michael Tokarev a écrit : > Andrey Vagin wrote: > > From: Krishna Kumar <krkumar2@...ibm.com> > > > > commit 068a2de57ddf4f472e32e7af868613c574ad1d88 upstream. > > > > Non-GSO code drops dst entry for performance reasons, but > > the same is missing for GSO code. Drop dst while cache-hot > > for GSO case too. > > > > Note: Without this patch the kernel may oops if used bridged veth > > devices. A bridge set skb->dst = fake_dst_ops, veth transfers this skb > > to netif_receive_skb...ip_rcv_finish and it calls dst_input(skb), but > > fake_dst_ops->input = NULL -> Oops > > Hmm. Isn't this the reason for my mysterious OOPSes (jump to > NULL) which I concluded are due to stack overflow? See f.e. > http://www.spinics.net/lists/netdev/msg142104.html > > This started happening when I updated virtio drivers in a windows > virtual machne to the ones which supports GSO, and my config > involves bridging veth devices, and this is where the prob > actually occurs - when doing guest => virtio => tap => bridge => veth > route.... > > Thanks! This patch was an optimization, not a bug fix. If something gets better, then a bug is somewhere else ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists