netdev - Re: [PATCH] net: clear heap allocations for privileged ethtool actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101011.122433.28818013.davem@davemloft.net>
Date:	Mon, 11 Oct 2010 12:24:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	kees.cook@...onical.com, linux-kernel@...r.kernel.org,
	jgarzik@...hat.com, jeffrey.t.kirsher@...el.com,
	peter.p.waskiewicz.jr@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: clear heap allocations for privileged ethtool
 actions

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 07 Oct 2010 22:34:44 +0100

> On Thu, 2010-10-07 at 14:10 -0700, Kees Cook wrote:
>> Several other ethtool functions leave heap uncleared (potentially) by
>> drivers. Some interfaces appear safe (eeprom, etc), in that the sizes
>> are well controlled. In some situations (e.g. unchecked error conditions),
>> the heap will remain unchanged in areas before copying back to userspace.
>> Note that these are less of an issue since these all require CAP_NET_ADMIN.
>> 
>> Cc: stable@...nel.org
>> Signed-off-by: Kees Cook <kees.cook@...onical.com>
 ...
> Acked-by: Ben Hutchings <bhutchings@...arflare.com>

So I've applied Kees's patch to net-2.6, and I'll merge net-2.6
into net-next-2.6 so I can resolve the vmalloc/kzalloc merge
conflict before Stephen Rothwell and others have to deal with it
in -next.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html