netdev - Re: [PATCH net-next] ixgbe: fix stats handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=iWq40SX7nqM-SUwvkOSBQAp_2EFgSkc6WHGEy@mail.gmail.com>
Date:	Mon, 11 Oct 2010 17:13:06 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Peter Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	Emil Tantilov <emil.s.tantilov@...el.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ixgbe: fix stats handling

On Mon, Oct 11, 2010 at 05:17, Eric Dumazet <eric.dumazet@...il.com> wrote:
> Hi
>
> I am sending this patch for Intel people review/test and acknowledge.
>
> Thanks !
>
> [PATCH net-next] ixgbe: fix stats handling
>
> Current ixgbe stats have following problems :
>
> - Not 64 bit safe (on 32bit arches)
>
> - Not safe in ixgbe_clean_rx_irq() :
>   All cpus dirty a common location (netdev->stats.rx_bytes &
> netdev->stats.rx_packets) without proper synchronization.
>   This slow down a bit multiqueue operations, and possibly miss some
> updates.
>
> Fixes :
>
> Implement ndo_get_stats64() method to provide accurate 64bit rx|tx
> bytes/packets counters, using 64bit safe infrastructure.
>
> ixgbe_get_ethtool_stats() also use this infrastructure to provide 64bit
> safe counters.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Peter Waskiewicz <peter.p.waskiewicz.jr@...el.com>
> CC: Emil Tantilov <emil.s.tantilov@...el.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ixgbe/ixgbe.h         |    3 +-
>  drivers/net/ixgbe/ixgbe_ethtool.c |   29 +++++++++++---------
>  drivers/net/ixgbe/ixgbe_main.c    |   40 +++++++++++++++++++++++++---
>  3 files changed, 56 insertions(+), 16 deletions(-)
>

Thanks Eric, I have added the patch to my queue.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html