netdev - Re: [PATCH -next] sundance: Add initial ethtool stats support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Oct 2010 13:57:19 -0700
From:	Joe Perches <joe@...ches.com>
To:	Denis Kirjanov <dkirjanov@...nel.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	eric.dumazet@...il.com, Ben Hutchings <bhutchings@...arflare.com>,
	Jeff Garzik <jgarzik@...hat.com>
Subject: Re: [PATCH -next] sundance: Add initial ethtool stats support

On Wed, 2010-10-13 at 00:36 +0400, Denis Kirjanov wrote:

> diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c

Hi Denis.
 
Just a few trivial misspellings of deffered -> deferred

> index 4283cc5..159f7e7 100644
> --- a/drivers/net/sundance.c
> +++ b/drivers/net/sundance.c
> @@ -363,6 +363,19 @@ struct netdev_private {
>          dma_addr_t tx_ring_dma;
>          dma_addr_t rx_ring_dma;
>  	struct timer_list timer;		/* Media monitoring timer. */
> +	/* ethtool extra stats */
> +	struct {
> +		u64 tx_multiple_collisions;
> +		u64 tx_single_collisions;
> +		u64 tx_late_collisions;
> +		u64 tx_deffered;
> +		u64 tx_deffered_excessive;

1

> +	np->xstats.tx_deffered += ioread8(ioaddr + StatsTxDefer);
> +	np->xstats.tx_deffered_excessive += ioread8(ioaddr + StatsTxXSDefer);

2

> +static const struct {
> +	const char name[ETH_GSTRING_LEN];
> +} sundance_stats[] = {
> +	{ "tx_multiple_collisions" },
> +	{ "tx_single_collisions" },
> +	{ "tx_late_collisions" },
> +	{ "tx_deffered" },
> +	{ "tx_deffered_excessive" },

3

> +	data[i++] = np->xstats.tx_deffered;
> +	data[i++] = np->xstats.tx_deffered_excessive;

4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html