netdev - [GIT PATCH] ioat2: fix performance regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101013230248.32594.35857.stgit@localhost6.localdomain6>
Date:	Wed, 13 Oct 2010 16:03:44 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org
Cc:	Dave Jiang <dave.jiang@...el.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	netdev@...r.kernel.org,
	Maciej Sosnowski <maciej.sosnowski@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	Richard Scobie <richard@...ce.co.nz>
Subject: [GIT PATCH] ioat2: fix performance regression

Commit 0793448 "DMAENGINE: generic channel status v2" changed the interface for
how dma channel progress is retrieved.  It inadvertently exported an internal
helper function ioat_tx_status() instead of ioat_dma_tx_status().  The latter
polls the hardware to get the latest completion state, while the helper just
evaluates the current state without touching hardware.  The effect is that we
end up waiting for completion timeouts or descriptor allocation errors before
the completion state is updated.

iperf (before fix):
[SUM]  0.0-41.3 sec   364 MBytes  73.9 Mbits/sec

iperf (after fix):
[SUM]  0.0- 4.5 sec   499 MBytes   940 Mbits/sec

This is a regression starting with 2.6.35.

Cc: <stable@...nel.org>
Cc: Dave Jiang <dave.jiang@...el.com>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc: Linus Walleij <linus.walleij@...ricsson.com>
Cc: Maciej Sosnowski <maciej.sosnowski@...el.com>
Reported-by: Richard Scobie <richard@...ce.co.nz>
Signed-off-by: Dan Williams <dan.j.williams@...el.com>
---
Late breaking fix that can hopefully get into 2.6.36.  I will queue a
cleanup to clarify this confusing naming convention for 2.6.37.

Also available via git:

  git://git.kernel.org/pub/scm/linux/kernel/git/djbw/async_tx.git fixes

Dan Williams (1):
      ioat2: fix performance regression

 drivers/dma/ioat/dma_v2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c
index 216f9d3..effd140 100644
--- a/drivers/dma/ioat/dma_v2.c
+++ b/drivers/dma/ioat/dma_v2.c
@@ -879,7 +879,7 @@ int __devinit ioat2_dma_probe(struct ioatdma_device *device, int dca)
 	dma->device_issue_pending = ioat2_issue_pending;
 	dma->device_alloc_chan_resources = ioat2_alloc_chan_resources;
 	dma->device_free_chan_resources = ioat2_free_chan_resources;
-	dma->device_tx_status = ioat_tx_status;
+	dma->device_tx_status = ioat_dma_tx_status;
 
 	err = ioat_probe(device);
 	if (err)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html