netdev - Re: [PATCH net-next] bonding: make release_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101015153725.GC7497@gospo.rdu.redhat.com>
Date:	Fri, 15 Oct 2010 11:37:25 -0400
From:	Andy Gospodarek <andy@...yhouse.net>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Jay Vosburgh <fubar@...ibm.com>,
	David Miller <davem@...emloft.net>,
	bonding-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bonding: make release_and_destroy static

On Fri, Oct 15, 2010 at 08:09:34AM -0700, Stephen Hemminger wrote:
> Only used in main file.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> --- a/drivers/net/bonding/bond_main.c	2010-10-15 08:07:14.163898236 -0700
> +++ b/drivers/net/bonding/bond_main.c	2010-10-15 08:07:31.956373660 -0700
> @@ -2057,8 +2057,8 @@ int bond_release(struct net_device *bond
>  * First release a slave and than destroy the bond if no more slaves are left.
>  * Must be under rtnl_lock when this function is called.
>  */
> -int  bond_release_and_destroy(struct net_device *bond_dev,
> -			      struct net_device *slave_dev)
> +static int  bond_release_and_destroy(struct net_device *bond_dev,
> +				     struct net_device *slave_dev)
>  {
>  	struct bonding *bond = netdev_priv(bond_dev);
>  	int ret;
> --- a/drivers/net/bonding/bonding.h	2010-10-15 08:07:14.179898632 -0700
> +++ b/drivers/net/bonding/bonding.h	2010-10-15 08:07:31.956373660 -0700
> @@ -334,7 +334,6 @@ static inline void bond_unset_master_alb
>  struct vlan_entry *bond_next_vlan(struct bonding *bond, struct vlan_entry *curr);
>  int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb, struct net_device *slave_dev);
>  int bond_create(struct net *net, const char *name);
> -int  bond_release_and_destroy(struct net_device *bond_dev, struct net_device *slave_dev);
>  int bond_create_sysfs(void);
>  void bond_destroy_sysfs(void);
>  void bond_prepare_sysfs_group(struct bonding *bond);

Seems fine.

Acked-by: Andy Gospodarek <andy@...yhouse.net>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html