netdev - Re: [PATCH net-next] netns: reorder fields in struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 17 Oct 2010 13:49:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] netns: reorder fields in struct net

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 14 Oct 2010 17:56:18 +0200

> In a network bench, I noticed an unfortunate false sharing between
> 'loopback_dev' and 'count' fields in "struct net".
> 
> 'count' is written each time a socket is created or destroyed, while
> loopback_dev might be often read in routing code.
> 
> Move loopback_dev in a read mostly section of "struct net"
> 
> Note: struct netns_xfrm is cache line aligned on SMP.
> (It contains a "struct dst_ops")
> Move it at the end to avoid holes, and reduce sizeof(struct net) by 128
> bytes on ia32.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html