netdev - Re: [PATCH 6/8] can: mcp251x: Don't use pdata->model for chip selection anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4c9d3f3d2843bd9cdb4cbb6a75236ce@localhost>
Date:	Mon, 18 Oct 2010 15:49:11 +0200
From:	Marc Zyngier <maz@...terjones.org>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	<socketcan-core@...ts.berlios.de>, <netdev@...r.kernel.org>,
	Christian Pellegrin <chripell@...e.org>
Subject: Re: [PATCH 6/8] can: mcp251x: Don't use pdata->model for chip selection
 anymore


On Mon, 18 Oct 2010 15:31:12 +0200, Marc Kleine-Budde <mkl@...gutronix.de>
wrote:
> Since commit e446630c960946b5c1762e4eadb618becef599e7, i.e. v2.6.35-rc1,
> the mcp251x chip model can be selected via the modalias member in the
> struct spi_board_info. The driver stores the actual model in the
> struct mcp251x_platform_data.
> 
> From the driver point of view the platform_data should be read only.
> Since all in-tree users of the mcp251x have already been converted to
> the modalias method, this patch moves the "model" member from the
> struct mcp251x_platform_data to the driver's private data structure.
> 
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> Cc: Christian Pellegrin <chripell@...e.org>
> Cc: Marc Zyngier <maz@...terjones.org>

Acked-by: Marc Zyngier <maz@...terjones.org>
-- 
Who you jivin' with that Cosmik Debris?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html