netdev - Re: [PATCH 6/8] can: mcp251x: Don't use pdata->model for chip selection anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CBC5662.6070302@pengutronix.de>
Date:	Mon, 18 Oct 2010 16:14:58 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Marc Zyngier <maz@...terjones.org>
CC:	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org
Subject: Re: [PATCH 6/8] can: mcp251x: Don't use pdata->model for chip selection
 anymore

On 10/18/2010 03:49 PM, Marc Zyngier wrote:
> 
> On Mon, 18 Oct 2010 15:31:12 +0200, Marc Kleine-Budde <mkl@...gutronix.de>
> wrote:
>> Since commit e446630c960946b5c1762e4eadb618becef599e7, i.e. v2.6.35-rc1,
>> the mcp251x chip model can be selected via the modalias member in the
>> struct spi_board_info. The driver stores the actual model in the
>> struct mcp251x_platform_data.
>>
>> From the driver point of view the platform_data should be read only.
>> Since all in-tree users of the mcp251x have already been converted to
>> the modalias method, this patch moves the "model" member from the
>> struct mcp251x_platform_data to the driver's private data structure.
>>
>> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
>> Cc: Christian Pellegrin <chripell@...e.org>
>> Cc: Marc Zyngier <maz@...terjones.org>
> 
> Acked-by: Marc Zyngier <maz@...terjones.org>

Thanks, but I was to slow to push your Ack, David has pulled already.

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (263 bytes)