netdev - Re: [PATCH 2/3] cxgb4: function namespace cleanup (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CBC5F72.3070005@opengridcomputing.com>
Date:	Mon, 18 Oct 2010 09:53:38 -0500
From:	Steve Wise <swise@...ngridcomputing.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	Dimitris Michailidis <dm@...lsio.com>,
	Divy Le Ray <divy@...lsio.com>,
	"David S. Miller" <davem@...emloft.net>,
	Casey Leedom <leedom@...lsio.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] cxgb4: function namespace cleanup (v2)

On 10/18/2010 09:47 AM, Stephen Hemminger wrote:
> On Sat, 16 Oct 2010 22:30:16 -0500
> Steve Wise<swise@...ngridcomputing.com>  wrote:
>
>    
>> On 10/16/2010 1:16 AM, Dimitris Michailidis wrote:
>>      
>>> Stephen Hemminger wrote:
>>>        
>>>> On Fri, 15 Oct 2010 18:11:42 -0700
>>>> Dimitris Michailidis<dm@...lsio.com>  wrote:
>>>>
>>>>          
>>>>> Stephen Hemminger wrote:
>>>>>            
>>>>>> Make functions only used in one file local.
>>>>>> Remove lots of dead code, relating to unsupported functions
>>>>>> in mainline driver like RSS, IPv6, and TCP offload.
>>>>>>              
>>>>> Thanks, this looks OK.  One exception, cxgb4_get_tcp_stats was
>>>>> intended to be used by the rdma driver.  I see that driver doesn't
>>>>> call it presently but if you don't mind can we give Steve a few
>>>>> hours to tell us if he has any imminent plans to use it.  If he
>>>>> doesn't offer to do something to use it for .37 it goes.
>>>>>            
>>>> The kernel source tree is not your development place holder tree.
>>>> At least #ifdef the code out for now.
>>>>          
>>> I am trying to protect Stephen Rothwell's time by checking that the IB
>>> folks don't plan to add a call to this in their tree while we remove
>>> the function in net-next.  There's supposed to be a call in the IB
>>> driver.  I don't know why there isn't one or whether they are planning
>>> to fix it for .37.  I see the potential for a linux-next conflict and
>>> I am trying to avoid it.  #ifdef doesn't help, if it's not needed we
>>> can remove it for good.
>>>        
>> I'll add a patch this week to utilize the tcp stats.
>>      
> In cxgb4 only or both cxgb3 and cxgb4?
>    

iw_cxgb3 already uses the cxgb3 TCP MIB.


Steve.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html