netdev - Re: [PATCH] bonding: various fixes for bonding, netpoll & netconsole (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101018155748.GB16326@hmsreliant.think-freely.org>
Date:	Mon, 18 Oct 2010 11:57:48 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net,
	fubar@...ibm.com, andy@...yhouse.net, amwang@...hat.com
Subject: Re: [PATCH] bonding: various fixes for bonding, netpoll & netconsole
 (v3)

On Mon, Oct 18, 2010 at 08:27:28AM -0700, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Mon, 18 Oct 2010 08:25:29 -0700 (PDT)
> 
> > From: nhorman@...driver.com
> > Date: Wed, 13 Oct 2010 22:01:48 -0400
> > 
> >> Version 3, taking the following changes into account:
> >  ...
> >> Signed-off-by: Neil Horman <nhorman@...driver.com>
> > 
> > Applied, thanks Neil.
> 
> This doesn't build with netpoll disable:
> 
> drivers/net/bonding/bond_main.c: In function ‘bond_start_xmit’:
> drivers/net/bonding/bond_main.c:4578: error: expected expression before ‘)’ token
> 
> I'll fix this up but please properly build test your
> changes next time.


I apologize Dave, I thought I had tested with CONFIG_NET_POLL_CONTROLLER turned
off, but apparently it just got re-enabled automatically because I had
CONFIG_NETPOLL on.  I'll check that more carefully in the future.
Neil


P.S. I've got some minor cleanup patches to this series (little things that I
missed) in the next day or so.

Thanks!

Neil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html