netdev - Re: [PATCH V3 net-next] can-raw: add msg_flags to distinguish local traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CBD81FF.5070004@hartkopp.net>
Date:	Tue, 19 Oct 2010 13:33:19 +0200
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	Kurt Van Dijck <kurt.van.dijck@....be>
CC:	Wolfgang Grandegger <wg@...ndegger.com>,
	Alexander Stein <alexander.stein@...tec-electronic.com>,
	socketcan-core@...ts.berlios.de, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH V3 net-next] can-raw: add msg_flags to distinguish local
 traffic

On 19.10.2010 13:16, Wolfgang Grandegger wrote:
> On 10/19/2010 12:28 PM, Alexander Stein wrote:
>> On Tuesday 19 October 2010, 11:57:03 Kurt Van Dijck wrote:
>>> On Tue, Oct 19, 2010 at 11:12:56AM +0200, Alexander Stein wrote:
>>>> You mixed tabs and spaces at MSG_CONFIRM entry. Dunno if that was
>>>> intended.
>>>
>>> That was not intended.
>>> Is that a problem (I never studied the code style wrt. Documentation)?
>>
>> Dunno if this is a problem, I just stumbled over it.
> 
> Well, I think it's not worth an extra patch but should be fixed when the
> files need to be touched anyway (for other reasons/fixes).

But there's also no need to commit a broken indention.

>From my side i would prefer a V4 and you can put in my

Acked-by: Oliver Hartkopp <socketcan@...tkopp.net>

directly if you like.

Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html