netdev - Re: [PATCH 1/1] ARC vmac ethernet driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101019.065317.246538050.davem@davemloft.net>
Date:	Tue, 19 Oct 2010 06:53:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andreas.fenkart@...eamunlimited.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] ARC vmac ethernet driver.

From: Andreas Fenkart <andreas.fenkart@...eamunlimited.com>
Date: Fri, 15 Oct 2010 09:54:14 +0200

> +
> +#undef DEBUG
> +

Please remove this.

> +#if 0
> +	/* FIXME: what is it used for? */
> +	platform_set_drvdata(ap->dev, ap->mii_bus);
> +#endif

Resolve this one way or another, either figure out what it's used
for and keep it or remove it if it is unnedeed.

> +		/* IP header Alignment (14 byte Ethernet header) */
> +		skb_reserve(skb, 2);

Use "NET_IP_ALIGN", not "2", different architectures want to
use different values.

> +	skb_reserve(merge_skb, 2);

Same thing here, use NET_IP_ALIGN.

> +/* arcvmac private data structures */
> +struct vmac_buffer_desc {
> +	unsigned int info;
> +	dma_addr_t data;
> +};

If this is the actual descriptor used by the hardware you
cannot define it this way.

dma_addr_t is a variable type, on some platforms it is a
"u32", on others it is a "u64" but you cannot assume one
way or another.

Also, are these values big or little endian?  You must use
the appropriate endian types such as __be32 et al. and then
access the members using the proper conversion functions.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html