netdev - Re: [PATCH net-next] net: avoid RCU for NOCACHE dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101020.030308.39191390.davem@davemloft.net>
Date:	Wed, 20 Oct 2010 03:03:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: avoid RCU for NOCACHE dst

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 15 Oct 2010 17:44:11 +0200

> There is no point using RCU for dst we allocate for a very short time
> (used once).
> 
> Change dst_release() to take DST_NOCACHE into account, but also change
> skb_dst_set_noref() to force a refcount increment for such dst.
> 
> This is a _huge_ gain, because we dont waste memory to store xx thousand
> of dsts. Instead of queueing them to RCU, we can free them instantly. 
 ...
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Wonderful, we are now faster without the routing cache. :-)

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html