netdev - Re: [RFC PATCH 5/9] ipvs network name space aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101021111644.GA25555@verge.net.au>
Date:	Thu, 21 Oct 2010 13:16:47 +0200
From:	Simon Horman <horms@...ge.net.au>
To:	Hans Schillstrom <hans.schillstrom@...csson.com>
Cc:	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, ja@....bg, wensong@...ux-vs.org,
	daniel.lezcano@...e.fr
Subject: Re: [RFC PATCH 5/9] ipvs network name space aware

On Fri, Oct 08, 2010 at 01:17:02PM +0200, Hans Schillstrom wrote:
> This patch just contains ip_vs_ctl
> 
> Signed-off-by:Hans Schillstrom <hans.schillstrom@...csson.com>
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index ca8ec8c..7e99cbc 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c

[ snip ]

> @@ -2680,10 +2664,15 @@ static int ip_vs_genl_dump_services(struct sk_buff *skb,
>  	int idx = 0, i;
>  	int start = cb->args[0];
>  	struct ip_vs_service *svc;
> -
> +	struct net *net = skb->sk->sk_net;

skb->sk->sk_net needs CONFIG_NS_NET.
Is your plan for IPVS to unconditionally depend on CONFIG_NS_NET?
It would be nice to avoid that, but I fear it will be too messy.

> +	struct netns_ipvs *ipvs;
> +	if (!net)
> +		net = dev_net(skb->dev);
> +	BUG_ON(!net);
> +	ipvs = net->ipvs;
>  	mutex_lock(&__ip_vs_mutex);
>  	for (i = 0; i < IP_VS_SVC_TAB_SIZE; i++) {
> -		list_for_each_entry(svc, &ip_vs_svc_table[i], s_list) {
> +		list_for_each_entry(svc, &ipvs->ctl_svc_table[i], s_list) {
>  			if (++idx <= start)
>  				continue;
>  			if (ip_vs_genl_dump_service(skb, svc, cb) < 0) {

[ snip ]
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html