netdev - Re: [PATCHv2] vmxnet3: remove set_flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTiniqn3fzw+XBL6_xBahSHckuucth37tRsdrWrQ7@mail.gmail.com>
Date:	Thu, 21 Oct 2010 08:24:02 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	sbhatewara@...are.com, netdev@...r.kernel.org,
	shemminger@...tta.com
Subject: Re: [PATCHv2] vmxnet3: remove set_flag_le{16,64} helpers

On Thu, Oct 21, 2010 at 3:57 AM, David Miller <davem@...emloft.net> wrote:
> From: Harvey Harrison <harvey.harrison@...il.com>
> Date: Wed, 20 Oct 2010 23:32:01 -0700
>
>> It's easier to just annotate the constants as little endian types and set/clear
>> the flags directly.
>>
>> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
>> ---i
>> Sorry, missed a git add and left a line out of the previous patch.
>
> Could you please rebase this against net-next-2.6 since I've
> applied Stephen Hemminger's patch.
>

Sure, will do, I actually think there's an endian bug or two in this
driver that sparse catches
once you suppress the spew coming out of the
VMXNET_{READ,WRITE}_BAR{0,1} macros.

Why is this driver byteswapping everything to little-endian before
sticking it into writel()?  Isn't
writel() defined to write out in little-endian as per PCI?  Similarly
for swapping whatever it reads
in from readl()?

What am I missing?

Harevy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html