lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Oct 2010 11:12:55 +0200 (CEST) From: Jan Engelhardt <jengelh@...ozas.de> To: KOVACS Krisztian <hidden@...abit.hu> cc: netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, Patrick McHardy <kaber@...sh.net>, David Miller <davem@...emloft.net> Subject: Re: [PATCH 9/9] tproxy: use the interface primary IP address as a default value for --on-ip On Wednesday 2010-10-20 13:21, KOVACS Krisztian wrote: >+ >+ if (!ipv6_addr_any(user_laddr)) >+ return user_laddr; >+ laddr = NULL; >+ >+ rcu_read_lock(); >+ indev = __in6_dev_get(skb->dev); >+ if (indev) >+ list_for_each_entry(ifa, &indev->addr_list, if_list) { >+ /* FIXME: address selection */ Per our realworld discussion, I believe we should add checks for some conditions (RFC 4862 section 2): 1. ignore tentative addresses if (ifa->ifa_flags & IFA_F_TENTATIVE) continue; 2. tests for when the interface's ifa->preferred_lft == 0/deprecatedness: if (ctinfo == IP_CT_NEW/RELATED && (ifa->ifa_flags & IFA_F_DEPRECATED)) continue; 3. check for invalid addresses (There might be a flag like tentative..) if (ifa->valid_lft == 0) continue; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists