netdev - Re: [PATCH] bridge: make br_parse_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101021.031235.112594832.davem@davemloft.net>
Date:	Thu, 21 Oct 2010 03:12:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bandan.das@...atus.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: make br_parse_ip_options static

From: Bandan Das <bandan.das@...atus.com>
Date: Tue, 19 Oct 2010 07:22:34 -0400

> On  0, Stephen Hemminger <shemminger@...tta.com> wrote:
>> 
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>> 
>> --- a/net/bridge/br_netfilter.c	2010-10-18 17:01:36.903364885 -0700
>> +++ b/net/bridge/br_netfilter.c	2010-10-18 17:01:48.106569141 -0700
>> @@ -213,7 +213,7 @@ static inline void nf_bridge_update_prot
>>   * expected format
>>   */
>>  
>> -int br_parse_ip_options(struct sk_buff *skb)
>> +static int br_parse_ip_options(struct sk_buff *skb)
>>  {
>>  	struct ip_options *opt;
>>  	struct iphdr *iph;
>> 
> 
> My main motivation behind not making this static was that
> there would be possibly other places in the bridge code 
> (besides br_netfilter.c) where we enter the IP stack and might 
> want to call this. Not sure if it's indeed the case though..

You can un-static it when the use is added.

Patch applied, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html