netdev - Re: [net-next-2.6 PATCH 2/3] ixgbe: fix stats handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101021.035603.233701260.davem@davemloft.net>
Date:	Thu, 21 Oct 2010 03:56:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com, bphilips@...ell.com,
	eric.dumazet@...il.com, donald.c.skidmore@...el.com
Subject: Re: [net-next-2.6 PATCH 2/3] ixgbe: fix stats handling

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 21 Oct 2010 02:00:04 -0700

> From: Eric Dumazet <eric.dumazet@...il.com>
> 
> Current ixgbe stats have following problems :
> 
> - Not 64 bit safe (on 32bit arches)
> 
> - Not safe in ixgbe_clean_rx_irq() :
>    All cpus dirty a common location (netdev->stats.rx_bytes &
> netdev->stats.rx_packets) without proper synchronization.
>    This slow down a bit multiqueue operations, and possibly miss some
> updates.
> 
> Fixes :
> 
> Implement ndo_get_stats64() method to provide accurate 64bit rx|tx
> bytes/packets counters, using 64bit safe infrastructure.
> 
> ixgbe_get_ethtool_stats() also use this infrastructure to provide 64bit
> safe counters.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Acked-by: Don Skidmore <donald.c.skidmore@...el.com>
> Tested-by: Stephen Ko <stephen.s.ko@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html