netdev - Re: [PATCH 3/3] vmxnet3: fix typo setting confPA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1010221030530.9726@sbhatewara-dev1.eng.vmware.com>
Date:	Fri, 22 Oct 2010 10:31:58 -0700 (PDT)
From:	Shreyas Bhatewara <sbhatewara@...are.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"shemminger@...tta.com" <shemminger@...tta.com>
Subject: Re: [PATCH 3/3] vmxnet3: fix typo setting confPA




On Thu, 21 Oct 2010, Harvey Harrison wrote:

> It's a le64, not a le32, typo in one place only.
>

Sure it is. Thanks for the change.

Signed-off-by: Shreyas Bhatewara <sbhatewara@...are.com>

 
> Noticed by sparse:
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: warning: incorrect type in assignment (different base types)
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52:    expected restricted __le64 [usertype] confPA
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52:    got restricted __le32 [usertype] <noident>
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 2ea4b81..e3658e1 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -2665,7 +2665,7 @@ vmxnet3_resume(struct device *device)
>  	adapter->shared->devRead.pmConfDesc.confVer = cpu_to_le32(1);
>  	adapter->shared->devRead.pmConfDesc.confLen = cpu_to_le32(sizeof(
>  								  *pmConf));
> -	adapter->shared->devRead.pmConfDesc.confPA = cpu_to_le32(virt_to_phys(
> +	adapter->shared->devRead.pmConfDesc.confPA = cpu_to_le64(virt_to_phys(
>  								 pmConf));
>  
>  	netif_device_attach(netdev);
> -- 
> 1.7.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html