netdev - Re: [PATCH] atl1c: Add support for Atheros AR8152 and AR8152

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20101022203707.GD16209@tux>
Date:	Fri, 22 Oct 2010 13:37:07 -0700
From:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
To:	Luis Rodriguez <Luis.Rodriguez@...eros.com>
CC:	Ben Hutchings <ben@...adent.org.uk>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jie Yang <Jie.Yang@...eros.com>, <linux-team@...eros.com>
Subject: Re: [PATCH] atl1c: Add support for Atheros AR8152 and AR8152

On Mon, Oct 11, 2010 at 05:45:03PM -0700, Luis Rodriguez wrote:
> On Mon, Oct 11, 2010 at 03:28:21PM -0700, Ben Hutchings wrote:
> > On Mon, 2010-10-11 at 11:48 -0700, Luis R. Rodriguez wrote:
> > > On Sun, Oct 10, 2010 at 09:03:04PM -0700, David Miller wrote:
> > > > From: Ben Hutchings <ben@...adent.org.uk>
> > > > Date: Mon, 11 Oct 2010 02:18:50 +0100
> > > > 
> > > > > Your commit 496c185c9495629ef1c65387cb2594578393cfe0 "atl1c: Add support
> > > > > for Atheros AR8152 and AR8152" included the following changes:
> > > >  ...
> > > > >> +		if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b) {
> > > >  ...
> > > > >> +	if ((hw->nic_type == athr_l1c || hw->nic_type == athr_l2c)) {
> > > >  ...
> > > > > Shouldn't the first if-statement use the same condition as the second
> > > > > i.e. matching the previously-defined hardware types athr_l1c and
> > > > > athr_l2c?
> > > > 
> > > > Yeah that definitely looks like a bug to me.
> > > 
> > > Good catch, unfortunatley I don't have the source code I used to port
> > > this work the day I did this anymore locally, so adding 
> > > Jie Yang who is actually our maintainer for this driver.
> > > 
> > > Jie, can you please confirm if this patch is correct?
> > 
> > I was suggesting that the first condition was wrong and the second was
> > right.
> 
> Heh, thanks, Jie can you review?

Jie, have you had any chance to review?

  Luis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html