netdev - Re: [PATCH] pktgen: clean up handling of local/transient counter vars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 24 Oct 2010 15:23:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	paul.gortmaker@...driver.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] pktgen: clean up handling of local/transient counter
 vars

From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Mon, 18 Oct 2010 18:14:44 -0400

> The temporary variable "i" is needlessly initialized to zero
> in two distinct cases in this file:
> 
> 1) where it is set to zero and then used as an argument in an addition
> before being assigned a non-zero value.
> 
> 2) where it is only used in a standard/typical loop counter
> 
> For (1), simply delete assignment to zero and usages while still
> zero; for (2) simply make the loop start at zero as per standard
> practice as seen everywhere else in the same file.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html