netdev - Re: [PATCH net-next-2.6] jme: Support WoL after shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101024.155135.200373852.davem@davemloft.net>
Date:	Sun, 24 Oct 2010 15:51:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cooldavid@...ldavid.org
Cc:	netdev@...r.kernel.org, Taoga@...dex.ru, arieslee@...cron.com,
	devinchiu@...cron.com, hcchao@...cron.com, ethanhsiao@...cron.com
Subject: Re: [PATCH net-next-2.6] jme: Support WoL after shutdown

From: David Miller <davem@...emloft.net>
Date: Sun, 24 Oct 2010 15:42:27 -0700 (PDT)

> From: "Guo-Fu Tseng" <cooldavid@...ldavid.org>
> Date: Fri, 22 Oct 2010 09:33:40 +0800
> 
>> From: Guo-Fu Tseng <cooldavid@...ldavid.org>
>> 
>> Adding shutdown function that setup wake if wol is enabled.
>> Add jme_phy_on in jme_set_100m_half in case it is shutting down
>> or suspending when interface is down(phy_off by default).
>> 
>> Reported_and_helped_by: Сtac <Taoga@...dex.ru>
>> Signed-off-by: Guo-Fu Tseng <cooldavid@...ldavid.org>
> 
> Applied.

Actually, I had to undo this patch.  It generates build
failures:

drivers/net/jme.c: In function 'jme_powersave_phy':
drivers/net/jme.c:1672:3: error: implicit declaration of function 'jme_set_100m_half'
drivers/net/jme.c:1675:4: error: implicit declaration of function 'jme_wait_link'

I guess I'm one of the few people who build with CONFIG_PM
disabled :-)

Please fix this up and resubmit your patch.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html