netdev - Re: [PATCH 3/3] vmxnet3: fix typo setting confPA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=XUrRsNqCfMsyMQoXj2ufe-RPwrbNJMBTvttvW@mail.gmail.com>
Date:	Sun, 24 Oct 2010 18:46:27 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	sbhatewara@...are.com, netdev@...r.kernel.org,
	shemminger@...tta.com
Subject: Re: [PATCH 3/3] vmxnet3: fix typo setting confPA

On Sun, Oct 24, 2010 at 3:44 PM, David Miller <davem@...emloft.net> wrote:
> From: Harvey Harrison <harvey.harrison@...il.com>
>> <sbhatewara@...are.com> wrote:
>>> Because values need to be written in LE orders in registers. For eg. when rx_ring.next2fill index is written to RXPROD reg, it should be converted from CPU order to LE.
>>
>> Yes, but (unless I'm mistaken) writel always writes out in
>> little-endian, so there isn't a need to swap the arguments,
>> similarly for readl in the other direction.
>
> That's right, readl() and writel() translate to little-endian.
>

OK, I'll submit patches for this and one more endian fix I found (only
visible on BE)

Harvey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html