netdev - Re: [PATCH] tg3: Do not call device_set_wakeup_enable() under spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101026.113432.68141914.davem@davemloft.net>
Date:	Tue, 26 Oct 2010 11:34:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rjw@...k.pl
Cc:	mcarlson@...adcom.com, mchan@...adcom.com, netdev@...r.kernel.org,
	maximlevitsky@...il.com
Subject: Re: [PATCH] tg3: Do not call device_set_wakeup_enable() under
 spin_lock_bh

From: "Rafael J. Wysocki" <rjw@...k.pl>
Date: Tue, 26 Oct 2010 01:01:55 +0200

> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> The tg3 driver calls device_set_wakeup_enable() under spin_lock_bh,
> which causes a problem to happen after the recent core power
> management changes, because this function can sleep now.  Fix this
> by moving the device_set_wakeup_enable() call out of the
> spin_lock_bh-protected area.
> 
> Reported-by: Maxim Levitsky <maximlevitsky@...il.com>
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

Applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html