netdev - Re: [net-next PATCH 1/3] qlge: Restoring the vlan setting.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinr5fHjgPNieYjJuegU2EKWiQG00rAeatZV_=3w@mail.gmail.com>
Date:	Mon, 25 Oct 2010 17:56:57 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	Ying Ping Lok <ying.lok@...gic.com>
Subject: Re: [net-next PATCH 1/3] qlge: Restoring the vlan setting.

On Mon, Oct 25, 2010 at 12:46 PM, Ron Mercer <ron.mercer@...gic.com> wrote:
> +static void qlge_restore_vlan(struct ql_adapter *qdev)
> +{
> +       qlge_vlan_rx_register(qdev->ndev, qdev->vlgrp);
> +
> +       if (qdev->vlgrp) {
> +               u16 vid;
> +               for (vid = 0; vid < VLAN_N_VID; vid++) {
> +                       if (!vlan_group_get_device(qdev->vlgrp, vid))
> +                               continue;
> +                       qlge_vlan_rx_add_vid(qdev->ndev, vid);
> +               }
> +       }
> +}

Using vlan groups within a driver is now deprecated.  I realize that
this is just a bug fix but it would nice if we can avoid introducing
more code around vlan groups.  Of course, fully switching the driver
over to use the new vlan model would be even nicer.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html