netdev - Re: [PATCH 1/2 v3] xps: Improvements in TX queue selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101026.083537.226783463.davem@davemloft.net>
Date:	Tue, 26 Oct 2010 08:35:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	helmut.schaa@...glemail.com, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH 1/2 v3] xps: Improvements in TX queue selection

From: Tom Herbert <therbert@...gle.com>
Date: Tue, 26 Oct 2010 08:32:59 -0700

>> Wouldn't that break mac80211 QoS again for bridged AP mode interfaces (see
>> commit deabc772f39405054a438d711f408d2d94d26d96, "net: fix tx queue selection
>> for bridged devices implementing select_queue")?
>>
> Yes, looks like that would break.  I'll fix that.
> 
> If a device only has one real TX queue should we still call
> ndo_select_queue, or can we bypass it? (to save one conditional)

Probably bypass, for now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html