netdev - Re: [PATCH] pktgen: Remove a dangerous debug print.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288208499.2658.19.camel@edumazet-laptop>
Date:	Wed, 27 Oct 2010 21:41:39 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nelson Elhage <nelhage@...lice.com>
Cc:	David Miller <davem@...emloft.net>, robert.olsson@....uu.se,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	eugene@...hat.com
Subject: Re: [PATCH] pktgen: Remove a dangerous debug print.

Le mercredi 27 octobre 2010 à 15:28 -0400, Nelson Elhage a écrit :
> How would you feel about limiting the debug print to at most, say, 512 or 1024
> bytes? Even if it's only accessible to root by default, I don't a userspace
> program should be able to accidentally corrupt the kernel stack by writing too
> many bytes to a file in /proc.

Arent /proc writes limited to PAGE_SIZE anyway ?

On x86 at least, you cannot corrupt kernel stack, since its bigger than
PAGE_SIZE.

I agree pktgen code is a bit ugly and needs a cleanup, but who
cares ? :)




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html